Fix/redundant network calls to notary during auth #1376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annekebr
force-pushed
the
fix/redundant-network-calls-to-notary-during-auth
branch
from
df07588 to
6ea9dac
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #1376 +/- ##
===========================================
+ Coverage 96.59% 96.64% +0.05%
===========================================
Files 23 23
Lines 1323 1343 +20
===========================================
+ Hits 1278 1298 +20
Misses 45 45 ☔ View full report in Codecov by Sentry. |
annekebr
force-pushed
the
fix/redundant-network-calls-to-notary-during-auth
branch
4 times, most recently
from
d5ed06f to
0588930
Compare
Starkteetje
reviewed
Nov 23, 2023
annekebr
force-pushed
the
fix/redundant-network-calls-to-notary-during-auth
branch
from
860fff8 to
7e11e81
Compare
Starkteetje
reviewed
Nov 23, 2023
Starkteetje
reviewed
Nov 24, 2023
Starkteetje
reviewed
Nov 27, 2023
annekebr
force-pushed
the
fix/redundant-network-calls-to-notary-during-auth
branch
2 times, most recently
from
602b98f to
25fe04b
Compare
Starkteetje
previously approved these changes
Nov 27, 2023
Currently, for each TUF role the first request is simply to get the auth endpoint, the second is getting the actual auth token and only the third fetches the actual data. For four roles that makes 12 requests in total. Now, the auth token should be fetched beforehand (2 calls) resulting in 6 calls in total.
annekebr
force-pushed
the
fix/redundant-network-calls-to-notary-during-auth
branch
from
25fe04b to
b2cd4a6
Compare
Starkteetje
approved these changes
Nov 27, 2023
annekebr
deleted the
fix/redundant-network-calls-to-notary-during-auth
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Description
Checklist
developChart.yaml(if necessary)